Add function ReflowVisibleGroupedTBBars#461
Open
senowak wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Grouped Tracking Bars were previously anchored statically based on their configured order. When an earlier grouped bar was hidden because its buff was inactive, later active bars kept their original anchors, leaving empty gaps in the group.
Changes
EllesmereUICdmBuffBars.lua only - dynamic grouped-bar reflow for Tracking Bars.
Dynamic reanchor for grouped Tracking Bars
Added a reflow pass that rebuilds the visible layout of grouped Tracking Bars based on currently shown bars only. The configured bar order is still respected as the hierarchy/source of truth, but inactive or hidden bars are skipped when calculating anchors.
Grow Direction aware positioning
The reflow uses the bar's configured grow direction, so active bars expand in the expected direction instead of always occupying fixed static slots.
Behaviour
Only Buff 2 active → Buff 2 occupies the first visible group position
Buff 2 and Buff 3 active → Buff 3 anchors after Buff 2 according to grow direction
Buff 1 becomes active → Buff 1 takes the first position, Buff 2 and Buff 3 move down/up accordingly
Buff 1 disappears → Buff 2 moves back into the first visible position, removing the gap
Why
This makes grouped Tracking Bars behave like a dynamic active-buff list rather than a fixed layout with hidden placeholders. It preserves user-defined priority/order while keeping the visible group compact.